order_modify error

puneetbijnor4020

in order_modify method there is error in bo and co order:
the method is not sending tradingsymbol and exchange parameter for bo and co order to api endpoint
which is resulting in internal server error.It should be like this:

if variety.lower() == "bo" and product.lower() == "bo":
			return self._put("orders.modify", {
				"order_id": order_id,
              "exchange":exchange,
              "tradingsymbol":tradingsymbol,
				"quantity": quantity,
				"price": price,
				"trigger_price": trigger_price,
				"disclosed_quantity": disclosed_quantity,
				"variety": variety,
				"parent_order_id": parent_order_id
			})["order_id"]
		elif variety.lower() == "co" and product.lower() == "co":
			return self._put("orders.modify", {
				"order_id": order_id,
              "exchange":exchange,
              "tradingsymbol":tradingsymbol,
				"trigger_price": trigger_price,
				"variety": variety,
				"parent_order_id": parent_order_id
			})["order_id"]

Vivek

Thanks for reporting, Will test and patch it if needed.

puneetbijnor4020

Welcome

puneetbijnor4020

@Vivek it has not been fixed yet

Vivek

@puneetbijnor4020 We are releasing a fix this week along with few other changes related to version 3 release. Will keep you updated on this.

puneetbijnor4020

lets see

Vivek

@puneetbijnor4020 Currently BO and CO orders doesn't require tradingsymbol to be sent sending it because these two are special API's for us internally and in the upcoming version we will be unified (User may not be required to send all the fields and only fields to change will be enough).

puneetbijnor4020

On that day api server was sending error for absence of tradingsymbol. Has this behavior been changed

Vivek

@puneetbijnor4020 Let me check in tomorrow market time since I have checked only with MCX now.

Vivek

@puneetbijnor4020 Please update to version 3.6.1 of Kite Connect python client in which the order modify issue should be fixed.