Error in PHP exitOrder()

ramatius

Hi,
The 3.0 PHP exitOrder( $params ) doesn't seem to be implemented correctly in kiteconnect.php.

The understanding is that $params is an array, like,

$params = array( "variety" => "co", "order_id" => "180222000270507", "parent_order_id" => "6546" );
$order_id = $kite->exitOrder( $params );

But in kiteconnect.php, the function is defined as,

public function exitOrder($params) {
return $this->cancelOrder($params);
}

However, cancelOrder function looks like,
public function cancelOrder($variety, $order_id, $params=null) {

Obviously, it is throwing an exception,
[Thu Feb 22 10:45:55.856893 2018] [:error] [pid 1636] [client IP:61223] PHP Warning: Missing argument 2 for KiteConnect::cancelOrder(), called in kiteconnect.php on line 423 and defined in kiteconnect.php on line 401

Our system CO squareoff function across all algos have gone for a six, the moment we migrated to 3.0.

Did you guys even test this at all?

Please clarify. This needs urgent correction.

Regards,
Ramakrishnan S

sujith

You need to pass array and parent order id inside that. We will update documentation.

ramatius

@sujith Can you please provide the correct equivalent call for the example I have given,

$params = array( "variety" => "co", "order_id" => "180222000270507", "parent_order_id" => "6546" );
$order_id = $kite->exitOrder( $params );

zartimus

@ramatius
$order_id = $kite->exitOrder("co", "180222000270507", array("parent_order_id" => "6546" ));

refer: https://github.com/zerodhatech/phpkiteconnect/blob/kite3/kiteconnect.php?utf8=✓#L413-L422

ramatius

@zartimus This call,
$order_id = $kite->exitOrder( "co", "180222000270507", array( "parent_order_id" => "6546") );

is throwing the following exception,

[Thu Feb 22 15:05:17.432210 2018] [:error] [pid 7500] [client IP:56434] PHP Warning: Missing argument 2 for KiteConnect::cancelOrder(), called in kiteconnect.php on line 423 and defined in kiteconnect.php on line 401
[Thu Feb 22 15:05:17.432270 2018] [:error] [pid 7500] [client IP:56434] PHP Notice: Undefined variable: order_id in kiteconnect.php on line 407

To save our time & effort, please actually try it out, verify that it works and then let me know.

zartimus

@ramatius working fine here. Undefined variable: order_id in kiteconnect.php means you are not passing order_id.

ramatius

@zartimus I have cut-pasted my code. You can see that order_id is being passed.

Obviously You and I are using different kiteconnect.php files.

To give you more info, I am using kiteconnect.php downloaded from https://github.com/zerodhatech/phpkiteconnect/releases/tag/v3.0.0-beta1 . I have downloaded it today morning.

Please clarify.

zartimus

@ramatius Released a new one now. https://github.com/zerodhatech/phpkiteconnect/releases/tag/v3.0.0-beta2

Otherwise you could have downloaded the php file from the kite3 branch manually as mentioned here https://github.com/zerodhatech/phpkiteconnect#installing

Hope it works.

ramatius

@zartimus Thanks, but this is throwing exception "'Incorrect `api_key` or `access_token`.'\n\n thrown in kiteconnect.php on line 899"

My code is,
$kite = new KiteConnect($api_key);
$kite->setAccessToken( $key );
$order_id = $kite->exitOrder( "co", "180222000270507", array( "parent_order_id" => "6546") );

This same code works with beta1 without the above error (but exitOrder() doesn't work).

Please see & let me know.

zartimus

@ramatius What is $key here? This should be the access token that you get after generateSession call. Can you go through the sample once.

ramatius

The $key is indeed access_token.
As I said, the auth is working fine with beta1 version of kiteconnect.php.

ramatius

@zartimus ok I am switching back to beta1 and using cancelOrder() directly instead of exitOrder(). It works. beta2 is continuing to fail in auth.

Please fix this issue properly in your next release.

zartimus

@ramatius auth works perfectly alright with https://github.com/zerodhatech/phpkiteconnect/releases/tag/v3.0.0-beta2

Double tested it.

ramatius

@zartimus will try it next week again.